paleolimbot commented on PR #1143: URL: https://github.com/apache/sedona-db/pull/1143#issuecomment-5254398058
Can you check `cargo bench -p s2geography` (possibly adding a new benchmark for Scalar st_area with a large number of vertices / polygon with a hole)? I am worried using area vs curvature will impact that result (although it may even make it faster). Because the affected code gets run for all geography input it will affect all functions (so we should at least measure what happens here). I would also tweak the phrasing of the title here...this is not fixing anything (invalid input causes undefined behaviour...also true for geometry with crossing edges), but does make geography functions less surprising for the current default behaviour of `ST_ToGeography()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
