jiayuasu opened a new pull request, #3270:
URL: https://github.com/apache/sedona/pull/3270

   ## Did you read the Contributor Guide?
   
   - Yes, I have read the [Contributor 
Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor 
Development Guide](https://sedona.apache.org/latest/community/develop/).
   
   ## Is this PR related to a ticket?
   
   - Yes, and the PR name follows the format `[GH-XXX] my subject`.
   
   Closes #3269.
   Part of #2230.
   
   ## What changes were proposed in this PR?
   
   GeoPandas warns when row-wise geometry predicates compare operands with 
different coordinate reference systems because identical coordinate values can 
represent different real-world locations under different CRSs. Sedona already 
provides that protection in newer distributed methods such as `shared_paths` 
and `geom_equals_identical`, but the older `geom_equals` and 
`geom_equals_exact` paths skipped CRS validation and silently returned boolean 
results.
   
   This PR aligns those predicates with GeoPandas by:
   
   - checking CRS metadata for GeoSeries, GeoDataFrame active-geometry, and 
geometry-typed pandas-on-Spark Series operands before alignment;
   - emitting exactly one standard CRS mismatch warning at the user's call site 
while preserving the row-wise result;
   - keeping matching CRS values, pairs with no CRS, and scalar Shapely 
operands warning-free;
   - preserving the public method signatures and the existing index-alignment 
behavior and warning attribution;
   - normalizing the one-column label representation of unnamed pandas-on-Spark 
geometry Series without collecting geometry rows; and
   - documenting the fix in the Sedona 2.0.0 release notes.
   
   ## How was this patch tested?
   
   - Focused CRS-warning, operand, alignment, and attribution coverage on 
GeoPandas 1.0.1: 8 tests passed.
   - The same focused matrix on GeoPandas 1.1.3: 8 tests passed.
   - Broader existing `geom_equals`, `geom_equals_exact`, 
`geom_equals_identical`, MultiIndex, duplicate-index, and GeoDataFrame 
delegation regressions: 29 tests passed.
   - Repository commit hooks passed for all four changed files, including 
Black, AST validation, Bandit, codespell, gitleaks, Markdown linting, and 
whitespace checks.
   - `git diff --check` passed.
   
   ## Did this PR include necessary documentation updates?
   
   - Yes, I updated the Sedona 2.0.0 release notes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to