minhpham1810 commented on issue #3174: URL: https://github.com/apache/sedona/issues/3174#issuecomment-5431950294
Hi @jiayuasu, I'd like to work on this issue. Plan: - Rework `isPolygonCW/isPolygonCCW` in `common/Functions.java` to recurse into `GeometryCollection` (including `MultiPolygon`, since it's a `GeometryCollection` subtype) and vacuously return true for inputs with no polygonal components (points, line strings, empty collections). - Update the Flink wrappers `ST_IsPolygonCW/ST_IsPolygonCCW in flink/.../expressions/Functions.java` from primitive boolean to nullable Boolean so SQL NULL propagates correctly. - Verify Spark and Snowflake already null-propagate correctly, adjusting if not. - Update the existing assertFalse assertions in FunctionsTest (and Spark/Flink/Snowflake test suites) that currently encode the old non-PostGIS behavior, and add coverage for the recursive/geometry-collection cases from this issue. - (Maybe) Add migration notes since this changes existing predicate results confirmed this lands cleanly since master is already 2.0.0-SNAPSHOT. Let me know what you think, then I'd be happy to put up a PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
