jiayuasu commented on code in PR #1194:
URL: https://github.com/apache/sedona-db/pull/1194#discussion_r3869842731
##########
rust/sedona-schema/src/matchers.rs:
##########
@@ -383,6 +402,32 @@ impl TypeMatcher for IsItemCrs {
}
}
+#[derive(Debug)]
+struct IsItemCrsOf {
+ item_matcher: Arc<dyn TypeMatcher + Send + Sync>,
+}
+
+impl TypeMatcher for IsItemCrsOf {
+ fn match_type(&self, arg: &SedonaType) -> bool {
+ if !arg.is_item_crs() {
Review Comment:
Would it be worth checking the `crs` field here too? `is_item_crs()` only
checks the field names, so a struct with a spatial `item` and `crs: Utf8` still
gets through even though these kernels read it as `Utf8View`. I tried that with
a Parquet column and got an internal downcast error; `ST_CRS` also hit a
return-type mismatch. Maybe `is_item_crs()` could require `Utf8View` for the
second field?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
