james-willis commented on PR #1203: URL: https://github.com/apache/sedona-db/pull/1203#issuecomment-5498483428
> I tend to like the style of writing a test that asserts a hard-coded result I am ambivalent on this. It would be good coverage but add complexity to the tests. I feel it is somewhat a mixing of concerns. > too many test helpers scattered in too many places Looking > Did you want to run these in CI? / Are they running in CI now? Probably will but not in this PR. I wanted to let this bake a little bit before doing so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
