james-willis commented on code in PR #1218:
URL: https://github.com/apache/sedona-db/pull/1218#discussion_r3917954098
##########
integration/spark-parity/test_rs_raster_out.py:
##########
@@ -190,20 +238,42 @@ def test_rs_setbandnodata_nan_on_float(dtype, tmp_path):
compare(sql, sedona, spark)
-def test_rs_setbandnodata_null_band_and_value(tmp_path):
- """A NULL band index or a NULL nodata value yields a NULL raster on both
- engines."""
+def test_rs_setbandnodata_null_band(tmp_path):
+ """A NULL band index yields a NULL raster on both engines."""
sedona, spark = SedonaDB(), SedonaSpark()
for eng in (sedona, spark):
eng.create_random_raster_view(
- "null_arg_src", tmp_path / "null_arg_src.tif", dtype="float64"
+ "null_band_src", tmp_path / "null_band_src.tif", dtype="float64"
)
- for sql in (
+ sql = (
"SELECT RS_SetBandNoDataValue(rast, CASE WHEN 1 = 0 THEN 1 END, 5.0) "
- "FROM null_arg_src",
- "SELECT RS_SetBandNoDataValue(rast, 1, CAST(NULL AS DOUBLE)) FROM
null_arg_src",
- ):
- compare(sql, sedona, spark)
+ "FROM null_band_src"
+ )
+ compare(sql, sedona, spark)
+
+
[email protected](
+ reason="SedonaDB reads a NULL nodata as 'clear this band's nodata' (the "
+ "trinary override semantics from #1198) and returns the raster; Sedona "
+ "Spark propagates the NULL and returns a NULL raster"
+)
Review Comment:
This silently broke because we dont run this in the CI yet. drive by fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
