james-willis commented on code in PR #1225:
URL: https://github.com/apache/sedona-db/pull/1225#discussion_r3929243960
##########
rust/sedona-functions/src/st_collect_agg.rs:
##########
@@ -525,4 +545,61 @@ mod test {
"CRS values not equal: ogc:crs84 vs epsg:3857"
);
}
+
+ /// The bitset swap must not change the serialized state wire format:
+ /// column 0 is a JSON list of geometry types and column 1 a JSON list of
+ /// dimensions wrapped as (Geometry, dims) pairs, exactly as the HashSet
+ /// implementation produced, so states merge across versions.
+ #[test]
+ fn state_wire_format_is_unchanged() {
Review Comment:
dropped this whole story by just changing the wire format. Agree that theres
no reason to be consistent across version about it. AFAIK all uses of it are
ephemeral
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
