[
https://issues.apache.org/jira/browse/SENTRY-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275481#comment-15275481
]
Hadoop QA commented on SENTRY-1233:
-----------------------------------
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12802779/SENTRY-1233.patch
against master.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} all tests passed
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/1538/console
This message is automatically generated.
> Logging improvements to SentryConfigToolSolr
> --------------------------------------------
>
> Key: SENTRY-1233
> URL: https://issues.apache.org/jira/browse/SENTRY-1233
> Project: Sentry
> Issue Type: Improvement
> Components: Solr Plugin
> Affects Versions: 1.8.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 1.8.0
>
> Attachments: SENTRY-1233.patch
>
>
> From working with this tool for a bit, I think the following additions would
> be useful:
> 1) The tool warns/errors on cased role names being converted to lower case,
> but still prints the cased name in the log. For clarity these should also be
> lower cased.
> 2) When not importing, we should still print a message about what we would
> do, i.e. a dry-run message.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
