[
https://issues.apache.org/jira/browse/SENTRY-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328273#comment-15328273
]
Colin Patrick McCabe commented on SENTRY-1319:
----------------------------------------------
Thanks, [~rahul9269]. Looks like a good start!
{code}
private final Boolean isHA;
private Boolean isActive;
{code}
Why are these boxed (i.e. {{Boolean}}) rather than just {{boolean}}?
{code}
1726 /* SENTRY-1319 */
1727 @Test
1728 public void testSentryServiceGauges() throws Throwable {
1729 String dbName = "db1";
{code}
I don't think we need a comment with the JIRA name. People can use git-blame
to find out which JIRA added these metrics.
I also don't think this should be in {{TestHDFSIntegration.java}} since it
doesn't have to do with testing the HDFS integration. Perhaps we should create
a new JUnit test file?
> Add metrics for isActive and isHA
> ---------------------------------
>
> Key: SENTRY-1319
> URL: https://issues.apache.org/jira/browse/SENTRY-1319
> Project: Sentry
> Issue Type: Sub-task
> Components: Hdfs Plugin
> Reporter: Colin Patrick McCabe
> Assignee: Rahul Sharma
> Fix For: 1.8.0
>
> Attachments: SENTRY-1319.1.patch
>
>
> Add metrics for isActive and isHA, so that admins and monitoring systems can
> know which sentry daemon is active, and whether HA is enabled.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
