[
https://issues.apache.org/jira/browse/SENTRY-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15347141#comment-15347141
]
Sravya Tirukkovalur commented on SENTRY-1329:
---------------------------------------------
Thanks for the feedback Colin! This is just a WIP patch, some end to end tests
fail if we just commit this one without implementing the handling off these
notifications(See SENTRY-1321). I am going to club these jiras and attach the
uber patch at SENTRY-1321. Will also add Review board link, so that it would be
easier to iterate.
> Add additional information in the NotificationLog entry
> -------------------------------------------------------
>
> Key: SENTRY-1329
> URL: https://issues.apache.org/jira/browse/SENTRY-1329
> Project: Sentry
> Issue Type: Sub-task
> Components: Hdfs Plugin
> Reporter: Sravya Tirukkovalur
> Assignee: Sravya Tirukkovalur
> Fix For: sentry-ha-redesign
>
> Attachments: SENTRY-1329.0.patch
>
>
> After some preliminary testing of HMS NotificationLog in Sentry
> (SENTRY-1324), we see that NotificationLog does not capture some information
> today. See this [comment|
> https://issues.apache.org/jira/browse/SENTRY-1324?focusedCommentId=15330859&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15330859]
> for more information.
> So with respect to capturing this information, the minimally invasive
> approach is to just implement a custom MessageFactory
> (hcatalog.message.factory.impl.json), which takes care of the serialization
> and deseriazation of the message. We can just add additional information
> without causing disruption to other clients.
> As I was implementing this, I encountered the problem that there is a small
> bug(in Hive trunk) which makes the MessageFactory not truly pluggable
> (HIVE-14011 - Attached a fix). But it would be a while before Hive can make a
> release with this fix and Sentry can move to this fixed version.
> So in the interim, we can implement the Listener in Sentry and use custom
> MessageFactory as well. I have done some testing on my side to make sure it
> does not break other clients.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
