[ 
https://issues.apache.org/jira/browse/SENTRY-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357670#comment-15357670
 ] 

Hao Hao commented on SENTRY-1376:
---------------------------------

[~sravya1812] Thanks for the fix! The changes look good to me, however there is 
a failure for applying the patch?

> Fix alter property case correctly - Deletes ACLS on the table
> -------------------------------------------------------------
>
>                 Key: SENTRY-1376
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1376
>             Project: Sentry
>          Issue Type: Bug
>            Reporter: Sravya Tirukkovalur
>            Assignee: Sravya Tirukkovalur
>         Attachments: SENTRY-1376.patch
>
>
> Sentry-1184 fixes the following bugs:
> - NPE - Caused for cases for Alter table renames when there are no partition 
> locations to oldName (test at SENTRY-1366) 
> - Alter table rename managed table with partitions - Old partition locations 
> will still have newName ACLS if they are recreated. Test case at SENTRY-1367
> But it caused a regression: 
> An alter table property - deletes all ACLS on the table. This is also 
> manifested in Insert, as insert calls alter table internally. SENTRY-1345 
> attempts to fix it, but is incomplete.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to