[ 
https://issues.apache.org/jira/browse/SENTRY-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15577383#comment-15577383
 ] 

Hadoop QA commented on SENTRY-1505:
-----------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12833484/SENTRY-1505.0.patch 
against master.

{color:red}Overall:{color} -1 due to 13 errors

{color:red}ERROR:{color} mvn test exited 1
{color:red}ERROR:{color} Failed: 
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtFunctionScope
{color:red}ERROR:{color} Failed: 
org.apache.sentry.provider.db.service.thrift.TestSentryServiceWithKerberos
{color:red}ERROR:{color} Failed: 
org.apache.sentry.provider.db.generic.service.thrift.TestAuditLogForSentryGenericService
{color:red}ERROR:{color} Failed: 
org.apache.sentry.provider.db.service.thrift.TestSentryServiceFailureCase
{color:red}ERROR:{color} Failed: 
org.apache.sentry.provider.db.service.thrift.TestSentryServiceForHAWithKerberos
{color:red}ERROR:{color} Failed: 
org.apache.sentry.provider.db.service.thrift.TestSentryServiceClientPool
{color:red}ERROR:{color} Failed: 
org.apache.sentry.provider.db.service.thrift.TestAuthorizingDDLAuditLogWithKerberos
{color:red}ERROR:{color} Failed: 
org.apache.sentry.provider.db.tools.TestSentryShellHive
{color:red}ERROR:{color} Failed: 
org.apache.sentry.provider.db.service.thrift.TestSentryServiceWithInvalidMsgSize
{color:red}ERROR:{color} Failed: 
org.apache.sentry.provider.db.service.thrift.TestSentryServiceForPoolHAWithKerberos
{color:red}ERROR:{color} Failed: 
org.apache.sentry.provider.db.generic.tools.TestSentryConfigToolSolr
{color:red}ERROR:{color} Failed: 
org.apache.sentry.provider.db.service.thrift.TestSentryWebServerWithoutSecurity

Console output: 
https://builds.apache.org/job/PreCommit-SENTRY-Build/2073/console

This message is automatically generated.

> CommitContext isn't used by anything and should be reoved
> ---------------------------------------------------------
>
>                 Key: SENTRY-1505
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1505
>             Project: Sentry
>          Issue Type: Improvement
>          Components: Sentry
>    Affects Versions: 1.7.0, sentry-ha-redesign
>            Reporter: Alexander Kolbasov
>            Assignee: Alexander Kolbasov
>            Priority: Minor
>         Attachments: SENTRY-1505.0.patch
>
>
> Sentry code defines class CommitContext which keeps track of sequence ID for 
> transaction. It is passed around many places in the server code but isn't 
> actually used by anything, so it is a dead code that should be trimmed. It 
> just complicates things without any benefit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to