[
https://issues.apache.org/jira/browse/SENTRY-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15631965#comment-15631965
]
Colin Ma commented on SENTRY-1505:
----------------------------------
[~akolb], it's ok to keep return a null Object for now, but I think the mockito
should be changed and work without return value. This can be a further
improvement.
+1 for the current implementation, thanks for the improvement.
> CommitContext isn't used by anything and should be removed
> ----------------------------------------------------------
>
> Key: SENTRY-1505
> URL: https://issues.apache.org/jira/browse/SENTRY-1505
> Project: Sentry
> Issue Type: Improvement
> Components: Sentry
> Affects Versions: 1.7.0, sentry-ha-redesign
> Reporter: Alexander Kolbasov
> Assignee: Alexander Kolbasov
> Priority: Minor
> Attachments: SENTRY-1505.0.patch, SENTRY-1505.1.patch,
> SENTRY-1505.2.patch
>
>
> Sentry code defines class CommitContext which keeps track of sequence ID for
> transaction. It is passed around many places in the server code but isn't
> actually used by anything, so it is a dead code that should be trimmed. It
> just complicates things without any benefit.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
