[
https://issues.apache.org/jira/browse/SENTRY-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717496#comment-15717496
]
Hadoop QA commented on SENTRY-1515:
-----------------------------------
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12841612/SENTRY-1515.001.patch
against master.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} all tests passed
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/2181/console
This message is automatically generated.
> Cleanup exception handling in SentryStore
> -----------------------------------------
>
> Key: SENTRY-1515
> URL: https://issues.apache.org/jira/browse/SENTRY-1515
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
> Affects Versions: sentry-ha-redesign
> Reporter: Alexander Kolbasov
> Assignee: Alexander Kolbasov
> Attachments: SENTRY-1515.001.patch
>
>
> The changes to SENTRY-1422 and SENTRY-1512 changed the semantics of several
> API calls:
> - hasAnyServerPrivileges
> - getMSentryPrivileges
> - getMSentryPrivilegesByAuth
> - getRoleNamesForGroups
> - retrieveFullPrivilegeImage
> - retrieveFullRoleImage
> - retrieveFullPathsImage
> - getAllRoleNames
> Previously they were not marked as throwing Exception, but they still could
> do it. With the change they now ignore exceptions and just log them which may
> not be the right thing to do.
> Instead they should be marked as throwing exceptions which has consequence
> for broader APIs which should be marked as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
