[
https://issues.apache.org/jira/browse/SENTRY-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kalyan kumar kalvagadda updated SENTRY-1556:
--------------------------------------------
Attachment: SENTRY-1556.003.patch
Added code changes to fix issues observed in unit tests and also addressed code
review comments and removed PrivCleaner class and it's usage. Added specific
cases to test orphan privileges.
There were issue observed with cascaded operations with the previous. They are
addressed in this commit.
> Simplify privilege cleaning
> ---------------------------
>
> Key: SENTRY-1556
> URL: https://issues.apache.org/jira/browse/SENTRY-1556
> Project: Sentry
> Issue Type: Improvement
> Components: Sentry
> Affects Versions: 1.8.0, sentry-ha-redesign
> Reporter: Alexander Kolbasov
> Assignee: kalyan kumar kalvagadda
> Priority: Minor
> Attachments: SENTRY-1556.002.patch, SENTRY-1556.003.patch
>
>
> The SentryStore class has a privCleaner that cleans up orphaned privileges.
> Currently cleaning is happening after 50 notification requests are sent and
> it uses locking to synchronize.
> I think the whole thing can be simplified:
> 1) We should consider whether it is possible to clean up a privilege simply
> when we see that there are no roles associated with it. In this case we do
> not need this at all.
> 2) We can simply run a periodic job to clean up orphaned privileges and
> groups (which are not cleaned up at all now).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
