[
https://issues.apache.org/jira/browse/SENTRY-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883932#comment-15883932
]
Hadoop QA commented on SENTRY-1625:
-----------------------------------
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12854628/SENTRY-1625.001-sentry-ha-redesign.patch
against sentry-ha-redesign.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} all tests passed
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/2372/console
This message is automatically generated.
> PrivilegeOperatePersistence can use QueryParamBuilder
> -----------------------------------------------------
>
> Key: SENTRY-1625
> URL: https://issues.apache.org/jira/browse/SENTRY-1625
> Project: Sentry
> Issue Type: Improvement
> Components: Sentry
> Affects Versions: 1.8.0, sentry-ha-redesign
> Reporter: Alexander Kolbasov
> Assignee: Alexander Kolbasov
> Fix For: 1.8.0
>
> Attachments: SENTRY-1625.001-sentry-ha-redesign.patch
>
>
> PrivilegeOperatePersistence has a few places where it builds queries using
> {{StringBuilder}}. It can benefit from the new {{QueryParamBuilder}}
> introduced in {{SentryStore}}.
> So I moved QueryParamBuilder to a separate class, moved a few methods from
> {{MSentryGMPrivilege}} to {{PrivilegeOperatePersistence}} (they were only
> used there) and converted all string-based query builders to
> QueryParamBuilder.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
