[ 
https://issues.apache.org/jira/browse/SENTRY-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926784#comment-15926784
 ] 

Alexander Kolbasov edited comment on SENTRY-1660 at 3/15/17 7:11 PM:
---------------------------------------------------------------------

This failure is completely unrelated - we have these all the time from tests. 
Can you resubmit the patch?


was (Author: akolb):
This failure is completely unrelated - we have these all the time from tests.

> Useless code in ResourceAuthorizationProvider
> ---------------------------------------------
>
>                 Key: SENTRY-1660
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1660
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 1.8.0
>            Reporter: Alexander Kolbasov
>            Assignee: Jan Hentschel
>            Priority: Minor
>              Labels: bite-sized, newbie
>         Attachments: SENTRY-1660.001.patch
>
>
> The ResourceAuthorizationProvider class has the following code:
> {code}
>     Set<String> hierarchy = new HashSet<String>();
>     for (Authorizable authorizable : authorizables) {
>       hierarchy.add(KV_JOINER.join(authorizable.getTypeName(), 
> authorizable.getName()));
>     }
> {code}
> The {{hierarchy}} variable is never used afterwords, so this code is 
> completely useless.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to