[
https://issues.apache.org/jira/browse/SENTRY-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926788#comment-15926788
]
Alexander Kolbasov commented on SENTRY-1660:
--------------------------------------------
[~Jan Hentschel] The fix is perfectly fine, but I am somewhat concerned that
there may be a different bug lurking here. As a due diligence, can you double
check what could be the intention here?
> Useless code in ResourceAuthorizationProvider
> ---------------------------------------------
>
> Key: SENTRY-1660
> URL: https://issues.apache.org/jira/browse/SENTRY-1660
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
> Affects Versions: 1.8.0
> Reporter: Alexander Kolbasov
> Assignee: Jan Hentschel
> Priority: Minor
> Labels: bite-sized, newbie
> Attachments: SENTRY-1660.001.patch
>
>
> The ResourceAuthorizationProvider class has the following code:
> {code}
> Set<String> hierarchy = new HashSet<String>();
> for (Authorizable authorizable : authorizables) {
> hierarchy.add(KV_JOINER.join(authorizable.getTypeName(),
> authorizable.getName()));
> }
> {code}
> The {{hierarchy}} variable is never used afterwords, so this code is
> completely useless.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
