[ 
https://issues.apache.org/jira/browse/SENTRY-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957061#comment-15957061
 ] 

Alexander Kolbasov commented on SENTRY-1647:
--------------------------------------------

The relationship between SentryPolicyStoreProcessor and HMSFollower and 
SentryStore is rather weird, but it is what it is for now. HMSFollower itself 
should be a singleton, counterWeight shouldn't. What you are suggesting works 
but is a bit ugly as well since now Thrift needs to know about HMSFollower 
which shouldn't be the case.

Please feel free to take this JIRA. It isn't very important though since what 
we have now works (even though it rather clunky).

> Move thrift waiters gauge away from SentryStore
> -----------------------------------------------
>
>                 Key: SENTRY-1647
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1647
>             Project: Sentry
>          Issue Type: Sub-task
>          Components: Sentry
>    Affects Versions: sentry-ha-redesign
>            Reporter: Alexander Kolbasov
>            Assignee: Alexander Kolbasov
>            Priority: Minor
>
> During code review for SENTRY-1601 [~kkalyan] suggested that SentryStore is 
> the wrong place for the gauge measuring number of thrift waiters. We should 
> move it to a more appropriate place.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to