[
https://issues.apache.org/jira/browse/SENTRY-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992466#comment-15992466
]
Hadoop QA commented on SENTRY-1743:
-----------------------------------
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12865838/SENTRY-1743.001.patch
against master.
{color:red}Overall:{color} -1 due to 26 errors
{color:red}ERROR:{color} mvn test exited 1
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryWebServerWithKerberos
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServerForPoolHAWithoutKerberos
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryWebServerWithSSL
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServerForPoolWithoutKerberos
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryWebServerWithoutSecurity
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServiceWithInvalidMsgSize
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServerForHaWithoutKerberos
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServiceClientPool
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServiceForPoolWithKerberos
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.generic.tools.TestSentryShellKafka
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.generic.service.thrift.TestAuditLogForSentryGenericService
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.generic.tools.TestSentryShellSolr
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServerWithoutKerberos
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServiceIntegration
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.generic.service.persistent.TestDelegateSentryStore
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServiceWithKerberos
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServiceForHAWithKerberos
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.generic.tools.TestSentryConfigToolSolr
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.generic.service.persistent.TestPrivilegeOperatePersistence
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServiceForPoolHAWithKerberos
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestAuthorizingDDLAuditLogWithKerberos
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServiceImportExport
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.generic.service.thrift.TestSentryGenericServiceIntegration
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.tools.TestSentryShellHive
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServiceFailureCase
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/2620/console
This message is automatically generated.
> Two SentryStore instances are one too many
> ------------------------------------------
>
> Key: SENTRY-1743
> URL: https://issues.apache.org/jira/browse/SENTRY-1743
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
> Affects Versions: 1.8.0, sentry-ha-redesign
> Reporter: Alexander Kolbasov
> Assignee: Alexander Kolbasov
> Attachments: SENTRY-1743.001.patch
>
>
> It turns out that we are creating multiple SentryStore instances each with
> its own Persistence manager factory which is wrong - we should create only
> one.
> 1) SentryService creates one in its constructor
> 2) DelegateSentryStore creates another one which is rather bad
> 3) SentryAdminServlet creates another one every time it shows some info
> We should use a single one.
> There are also some instances created by tests:
> - TestSentryStore creates one - this is probably Ok
> - TestSentryStoreImportExport - this is probably Ok as well
> - TestSentryVersion - this may be Ok, but probably this should be merged to
> TestSentryStore
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
