[ 
https://issues.apache.org/jira/browse/SENTRY-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004777#comment-16004777
 ] 

Na Li commented on SENTRY-1757:
-------------------------------

2) in "TestHDFSIntegrationBase.startHiveAndMetastore(final int retries)", 
hive-site.xml is created in following code. It saves HiveConf into a file.

        File hiveSite = new File(confDir, "hive-site.xml");
        out = new FileOutputStream(hiveSite);
        hiveConf.writeXml(out);
        out.close();

This code gets HMS port
hmsPort = findPort();

> Avoid using local hive meta store using wrong configuration
> -----------------------------------------------------------
>
>                 Key: SENTRY-1757
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1757
>             Project: Sentry
>          Issue Type: Sub-task
>          Components: Sentry
>    Affects Versions: sentry-ha-redesign
>            Reporter: Na Li
>            Assignee: Na Li
>            Priority: Blocker
>              Labels: security
>             Fix For: sentry-ha-redesign
>
>         Attachments: SENTRY-1757.001-sentry-ha-redesign.patch
>
>
> When HMSFollower.getMetaStoreClient() checks if it should create 
> HiveMetaStoreClient, it uses the input configuration from SentryService.
> In real cluster deployment, the configuration does not contain value for 
> "hive.metastore.uris", and therefore, HMSFollower never connects to the real 
> meta store. 
> In integration test, the configuration contains value for 
> "hive.metastore.uris". Therefore integration tests pass. 
> We need to check Hive configuration to avoid connecting to local meta store. 
> And remove the value for "hive.metastore.uris" in integration test, so its 
> behavior is the same as real cluster deployment.
> TestHDFSIntegrationBase.startSentry() `properties.put("hive.metastore.uris", 
> "thrift://localhost:" + hmsPort);` is introduced in SENTRY-1429, SENTRY-1454, 
> and SENTRY-1456



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to