[ 
https://issues.apache.org/jira/browse/SENTRY-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008471#comment-16008471
 ] 

Alexander Kolbasov commented on SENTRY-1744:
--------------------------------------------

More arguments for simplifying this.

I think this is a typical case of over-engineering. There are no other possible 
processors and even if they would appear we can easily create them in the code 
- there is no need to do it dynamically via configuration. Especially for a 
security server which should be as simple and straightforward as possible - we 
should be very careful about executing arbitrary Java code that is obtained via 
configuration files.

> Simplify creation of DelegateSentryStore
> ----------------------------------------
>
>                 Key: SENTRY-1744
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1744
>             Project: Sentry
>          Issue Type: Improvement
>          Components: Sentry
>    Affects Versions: 1.8.0, sentry-ha-redesign
>            Reporter: Alexander Kolbasov
>            Assignee: Alexander Kolbasov
>         Attachments: SENTRY-1744.001.patch
>
>
> It looks like we have a very "generic" code in SentryGenericPolicyProcessor 
> that creates DelegateSentryStore based on the class name which may be changed 
> in configuration. This is very cute, but sounds quite complicated to me. I 
> don't know the history here, but I would suggest removing this and just 
> creating DelegateSentryStore directly.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to