[
https://issues.apache.org/jira/browse/SENTRY-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020263#comment-16020263
]
Alexander Kolbasov commented on SENTRY-1778:
--------------------------------------------
To clarify " the memory leak without this change should not be significant." -
do you think that we have *any* query leak without this change? If yes, we
should fix it.
Otherwise it seems to be a good general practice to close query once they are
no longer needed.
> Close query as soon as it is done
> ---------------------------------
>
> Key: SENTRY-1778
> URL: https://issues.apache.org/jira/browse/SENTRY-1778
> Project: Sentry
> Issue Type: Sub-task
> Components: Sentry
> Affects Versions: 1.8.0, sentry-ha-redesign
> Reporter: Na Li
> Assignee: Na Li
> Priority: Minor
>
> Make sure we close all query results after we have finished with them.
> Failure to do so will result in significant memory leaks in your application.
> mentioned in
> http://www.datanucleus.org/products/accessplatform_4_1/jdo/performance_tuning.html
> Since we always close the transaction, and closing transaction will close the
> query, the memory leak without this change should not be significant. This is
> why this issue is not high priority. On the other hand, closing query result
> sooner should not have side effect.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
