[
https://issues.apache.org/jira/browse/SENTRY-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048760#comment-16048760
]
Hadoop QA commented on SENTRY-1743:
-----------------------------------
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12872910/SENTRY-1743.01-sentry-ha-redesign.patch
against sentry-ha-redesign.
{color:red}Overall:{color} -1 due to 91 errors
{color:red}ERROR:{color} mvn test exited 1
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestURIMetastore
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestURIMetastore
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestURIMetastore
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbMetadataPermissions
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbMetadataPermissions
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbMetadataPermissions
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbMetadataPermissions
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbMetadataPermissions
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbExportImportPrivileges
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbExportImportPrivileges
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbExportImportPrivileges
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hdfs.TestDbHdfsExtMaxGroups
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegeAtTransform
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegeAtTransform
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtTableScopePart2
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtTableScopePart2
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtTableScopePart2
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtTableScopePart2
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtTableScopePart2
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestSentryListenerInBuiltDeserializer
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbMovingToProduction
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbMovingToProduction
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbMovingToProduction
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbComplexView
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbComplexView
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbComplexView
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestAuthorizingObjectStore
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestAuthorizingObjectStore
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestAuthorizingObjectStore
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestAuthorizingObjectStore
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestAuthorizingObjectStore
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestAuthorizingObjectStore
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestDBNotificationListenerInBuiltDeserializer
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestSentryListenerSentryDeserializer
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hdfs.TestDbHdfsMaxGroups
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestGrantUserToRole
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestGrantUserToRole
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestGrantUserToRole
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestGrantUserToRole
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestConcurrentClients
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestConcurrentClients
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestConcurrentClients
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDatabaseProvider
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbCrossOperations
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbCrossOperations
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbCrossOperations
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.fs.TestTableOnExtFS
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbDDLAuditLog
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbDDLAuditLog
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPolicyImportExport
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPolicyImportExport
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPolicyImportExport
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbConnections
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbConnections
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegeCleanupOnDrop
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegeCleanupOnDrop
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegeCleanupOnDrop
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegeCleanupOnDrop
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegeCleanupOnDrop
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbJDBCInterface
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbJDBCInterface
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.fs.TestHiveWarehouseOnExtFs
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestDbNotificationListenerSentryDeserializer
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hdfs.TestHDFSIntegrationEnd2End
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestPrivilegeWithGrantOption
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestPrivilegeWithGrantOption
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestPrivilegeWithGrantOption
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestPrivilegeWithGrantOption
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestMetastoreEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestMetastoreEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestMetastoreEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestMetastoreEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestMetastoreEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestMetastoreEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestMetastoreEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestMetastoreEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestMetastoreEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestMetastoreEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestMetastoreEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestMetastoreEndToEnd
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/2880/console
This message is automatically generated.
> Two SentryStore instances are one too many
> ------------------------------------------
>
> Key: SENTRY-1743
> URL: https://issues.apache.org/jira/browse/SENTRY-1743
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
> Affects Versions: 1.8.0, sentry-ha-redesign
> Reporter: Alexander Kolbasov
> Assignee: Alexander Kolbasov
> Attachments: SENTRY-1743.01.patch,
> SENTRY-1743.01-sentry-ha-redesign.patch
>
>
> It turns out that we are creating multiple SentryStore instances each with
> its own Persistence manager factory which is wrong - we should create only
> one.
> 1) SentryService creates one in its constructor
> 2) DelegateSentryStore creates another one which is rather bad
> 3) SentryAdminServlet creates another one every time it shows some info
> We should use a single one.
> There are also some instances created by tests:
> - TestSentryStore creates one - this is probably Ok
> - TestSentryStoreImportExport - this is probably Ok as well
> - TestSentryVersion - this may be Ok, but probably this should be merged to
> TestSentryStore
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
