[
https://issues.apache.org/jira/browse/SENTRY-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065158#comment-16065158
]
Na Li commented on SENTRY-1750:
-------------------------------
[~akolb] Sentry does not need to do anything for a view event. Sentry-1669 made
the code change that does not throw exception when location of an event is null
(a possible view event). So the behavior is correct now.
Before, I have disabled the test "TestHDFSIntegrationEnd2End.testViews" because
it causes other tests to fail (the view event caused exception and then
following events are not processed, and this issue is tracked in SENTRY-1752).
Since the problem is fixed in Sentry-1669, the only thing left is to enable the
test, which is enabled in SENTRY-1793.
Therefore, I close this issue without any code change.
> HMSFollower does not handle view update correctly
> -------------------------------------------------
>
> Key: SENTRY-1750
> URL: https://issues.apache.org/jira/browse/SENTRY-1750
> Project: Sentry
> Issue Type: Sub-task
> Components: Sentry
> Affects Versions: sentry-ha-redesign
> Reporter: Na Li
> Assignee: Na Li
> Priority: Minor
> Labels: sentry-ha
> Fix For: sentry-ha-redesign
>
>
> The location of a view is null, and it should be accepted by Sentry. However,
> when there is view update such "create view testView as select * from test"
> in TestHDFSIntegrationEnd2End.testViews, the location is null, and
> HMSFollower throws exception when processing this notification.
> The notification uses HCatEventMessage.EventType. Should we add types for
> view? So sentry can process view and table differently.
> The call stack of exception
> 2017-05-04 23:24:00,198 (pool-5-thread-1) [ERROR -
> org.apache.sentry.service.thrift.HMSFollower.run(HMSFollower.java:300)]
> Encounter SentryInvalidInputException|SentryInvalidHMSEventException while
> processing notification log
> org.apache.sentry.core.common.exception.SentryInvalidHMSEventException:
> Create table event has incomplete information. dbName = default, tableName =
> testView, location = null
> at
> org.apache.sentry.service.thrift.HMSFollower.processNotificationEvents(HMSFollower.java:415)
> at
> org.apache.sentry.service.thrift.HMSFollower.run(HMSFollower.java:287)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
