[ 
https://issues.apache.org/jira/browse/SENTRY-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100338#comment-16100338
 ] 

Alexander Kolbasov commented on SENTRY-1755:
--------------------------------------------

[~lina.li] Why do you think that the code is lost? I see this code in 
{{SentryHMSClient}}:

{code}
  private Map<String, Set<String>> fetchFullUpdate() {
    LOGGER.info("Request full HMS snapshot");
    try (FullUpdateInitializer updateInitializer =
             new FullUpdateInitializer(hiveConnectionFactory, conf);
         Context context = updateTimer.time()) {
      Map<String, Set<String>> pathsUpdate = 
updateInitializer.getFullHMSSnapshot();
      LOGGER.info("Obtained full HMS snapshot");
      return pathsUpdate;
    } catch (Exception ignored) {
      failedSnapshotsCount.inc();
      LOGGER.error("Snapshot created failed ", ignored);
      return Collections.emptyMap();
    }
  }
{code}

What part is missing?

> Add HMSFollower per-operation metrics
> -------------------------------------
>
>                 Key: SENTRY-1755
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1755
>             Project: Sentry
>          Issue Type: Sub-task
>          Components: Sentry
>    Affects Versions: 2.0.0
>            Reporter: Alexander Kolbasov
>            Assignee: Alexander Kolbasov
>             Fix For: 2.0.0
>
>         Attachments: SENTRY-1755.01-sentry-ha-redesign.patch
>
>
> We need to get an idea of the time it takes to process HMS notifications on 
> the Sentry side using metrics.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to