[ 
https://issues.apache.org/jira/browse/SENTRY-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162400#comment-16162400
 ] 

Hadoop QA commented on SENTRY-1946:
-----------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12886551/SENTRY-1946.01-master.patch
 against master.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} all tests passed

Console output: 
https://builds.apache.org/job/PreCommit-SENTRY-Build/3281/console

This message is automatically generated.

> getPathsUpdatesFrom() got its boolean logic inversed which results in sending 
> two snapshots at the same time
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: SENTRY-1946
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1946
>             Project: Sentry
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Vamsee Yarlagadda
>            Assignee: Vamsee Yarlagadda
>         Attachments: SENTRY-1946.01-master.patch
>
>
> As part of SENTRY-1931, we added check not to send two NN snaphsots at the 
> same time. But because of a conditional typo, it results in sending back two 
> snapshots.
> {code}
>     // If another paths updates request is in progress by another HDFS 
> NameNode, then we
>     // return an empty image for now to avoid a large memory consumption
>     if (pathsRetrieverBusy.compareAndSet(false, true)) {
>       LOGGER.debug("PATHS updates are not available because another request 
> is in progress.");
>       return Collections.emptyList();
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to