[
https://issues.apache.org/jira/browse/SENTRY-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204069#comment-16204069
]
Sergio Peña commented on SENTRY-1893:
-------------------------------------
I don't think we need to revert SENTRY-1642 completely. The rest of the code
still applies. I'm just removing google error prone. But yeah, I will create
another jira to enable google error prone once we see good results in this
patch.
Regarding the issue, google error prone 2.0.9 and higher uses Java8, but when I
use any version of those, then an IncompatibleClassChangeError is thrown on the
Solr tests when SentryStore calls the transaction.close() from the
PersistenceManager. IncompatibleClassChangeError is an issue that happens when
there are incompatible binary changes on the JAR where the class#method exists.
This usually happens when such change is made in the class and the class was
built separately from the rest of the JAR (or something like that) leaving
incompatibilities on the binary.
I'm not sure how we're triggering the above issues with java8 and google error
prone, so for now I'm disabling it in order to move forward. Google error prone
is not an important dependency for Sentry, so we will be good for now.
> Bump the minimum java version to 8
> ----------------------------------
>
> Key: SENTRY-1893
> URL: https://issues.apache.org/jira/browse/SENTRY-1893
> Project: Sentry
> Issue Type: Task
> Affects Versions: 2.0.0
> Reporter: Hrishikesh Gadre
> Assignee: Sergio Peña
> Attachments: SENTRY-1893-001.patch, SENTRY-1893.2.patch,
> SENTRY-1893.3.patch, SENTRY-1893.4.patch, SENTRY-1983.5.patch
>
>
> The latest version of Solr (6.x) requires Java 8. Also it looks like Oracle
> has already [EOLed Java
> 7|http://www.oracle.com/technetwork/java/eol-135779.html]. It may be a good
> idea to bump the minimum JDK version for Sentry to Java 8 as well.
> Need to do as part of this version bump is:
> "When you switch to Java 8 you also need to update the version of error-prone
> to the latest one because it comes with Java7 compiler."
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
