[
https://issues.apache.org/jira/browse/SENTRY-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218418#comment-16218418
]
Hadoop QA commented on SENTRY-2013:
-----------------------------------
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12893906/SENTRY-2013.patch
against master.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} all tests passed
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/3380/console
This message is automatically generated.
> Align the SentryGenericServiceClient and SentryPolicyServiceClient a bit more
> closely
> -------------------------------------------------------------------------------------
>
> Key: SENTRY-2013
> URL: https://issues.apache.org/jira/browse/SENTRY-2013
> Project: Sentry
> Issue Type: Improvement
> Reporter: Colm O hEigeartaigh
> Assignee: Colm O hEigeartaigh
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: SENTRY-2013.patch
>
>
> The SentryPolicyServiceClient + SentryGenericServiceClient have a large
> number of shared methods, and a small number of methods with the same meaning
> but with slightly different names. This task is to align both clients so that
> the shared methods are called the same - this makes it a bit easier to read
> code when switching from generic to hive etc.
> The proposed changes are:
> SentryGenericServiceClient:
> addRoleToGroups -> grantRoleToGroups
> deleteRoleToGroups -> revokeRoleFromGroups
> listPrivilegesByRoleName -> listAllPrivilegesByRoleName
> SentryPolicyServiceClient:
> listRoles -> listAllRoles
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
