[ 
https://issues.apache.org/jira/browse/SENTRY-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222122#comment-16222122
 ] 

Mano Kovacs commented on SENTRY-2015:
-------------------------------------

I am still testing the previous one, changes mostly in 
{{GenericPrivilegeConverter}} and {{SentryShellGeneric}}. Will upload the patch 
today to reviewboard.

> Refactor Command implementations
> --------------------------------
>
>                 Key: SENTRY-2015
>                 URL: https://issues.apache.org/jira/browse/SENTRY-2015
>             Project: Sentry
>          Issue Type: Improvement
>            Reporter: Colm O hEigeartaigh
>            Assignee: Colm O hEigeartaigh
>             Fix For: 2.0.0
>
>         Attachments: SENTRY-2015.patch
>
>
> Right now, we have different Command implementations for each possible Shell 
> command for both the Hive and Generic versions. Instead, we should have a 
> single interface which encapsulates all of the different Commands, and then 
> two implementations for Hive + Generic. Apart from having a lot less simple 
> classes, this means that I can re-use this interface for the Sentry CLI work.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to