[ 
https://issues.apache.org/jira/browse/SENTRY-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245070#comment-16245070
 ] 

Alexander Kolbasov commented on SENTRY-2039:
--------------------------------------------

We shouldn't treat older code as the final source of truth. What do you think 
makes most sense semantics-wise? Are keys and values case-insensitive? Looks 
like the keys can be used for some enums at least so it would make sense to 
keep them in upcase always. I am not sure about values. I don't really know how 
they are used. If they are inherently case-insensitive, converting to a 
standard case makes sense.

> KeyValue is case sensitive and it causes incompatibility issues with external 
> components
> ----------------------------------------------------------------------------------------
>
>                 Key: SENTRY-2039
>                 URL: https://issues.apache.org/jira/browse/SENTRY-2039
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 1.8.0
>            Reporter: Sergio Peña
>            Assignee: Sergio Peña
>         Attachments: SENTRY-2039.1.patch, SENTRY-2039.2.patch
>
>
> A refactor done on SENTRY-999 changed the way KeyValue.equals() checks for 
> equality. It used to be case insensitive and now it is case sensitive. This 
> may cause issues (like hbase indexer) when policies are written with case 
> insensitive.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to