[
https://issues.apache.org/jira/browse/SENTRY-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254202#comment-16254202
]
Hadoop QA commented on SENTRY-2047:
-----------------------------------
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12897796/SENTRY-2047.01.patch
against master.
{color:red}Overall:{color} -1 due to 99 errors
{color:red}ERROR:{color} mvn test exited 1
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPrivilegesAtColumnScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPrivilegesAtColumnScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestViewPrivileges
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbCrossDbOps
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbCrossDbOps
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPrivilegesAtTableScopePart2
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestMovingToProduction
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestMovingToProduction
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbComplexView
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbComplexView
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbComplexView
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestOperationsPart2
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestOperationsPart2
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPrivilegeAtTransform
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtDatabaseScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtDatabaseScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtDatabaseScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPrivilegesAtFunctionScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPrivilegesAtFunctionScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPrivilegesAtFunctionScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPrivilegesAtFunctionScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPrivilegesAtFunctionScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPrivilegesAtFunctionScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbMovingToProduction
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbMovingToProduction
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbMovingToProduction
{color:red}ERROR:{color} Failed: org.apache.sentry.tests.e2e.hive.TestCrossDbOps
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestPrivilegeWithGrantOption
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestPrivilegeWithGrantOption
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPerDBConfiguration
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPerDBConfiguration
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPerDBConfiguration
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestExportImportPrivileges
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegeAtTransform
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegeAtTransform
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPrivilegesAtDatabaseScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPrivilegesAtDatabaseScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestOperationsPart1
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestOperationsPart1
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbExportImportPrivileges
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbExportImportPrivileges
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbColumnLevelMetaDataOps
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbColumnLevelMetaDataOps
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbColumnLevelMetaDataOps
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbColumnLevelMetaDataOps
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbColumnLevelMetaDataOps
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbColumnLevelMetaDataOps
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbColumnLevelMetaDataOps
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbColumnLevelMetaDataOps
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbColumnLevelMetaDataOps
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbOperationsPart2
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbOperationsPart2
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbOperationsPart2
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestMetastoreEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestMetastoreEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.metastore.TestMetastoreEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hdfs.TestHDFSIntegrationAdvanced
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbCrossOperations
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbCrossOperations
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbCrossOperations
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbOperationsPart1
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbOperationsPart1
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbOperationsPart1
{color:red}ERROR:{color} Failed: org.apache.sentry.tests.e2e.hive.TestEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPrivilegesAtTableScopePart1
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPrivilegesAtTableScopePart1
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPrivilegesAtTableScopePart1
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPrivilegesAtTableScopePart1
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.hive.TestPrivilegesAtTableScopePart1
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtTableScopePart1
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtTableScopePart1
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtTableScopePart1
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtTableScopePart1
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtTableScopePart1
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtTableScopePart1
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestColumnEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestColumnEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestColumnEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestColumnEndToEnd
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtTableScopePart2
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtTableScopePart2
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtFunctionScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtFunctionScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtFunctionScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtFunctionScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtFunctionScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtFunctionScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtFunctionScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtColumnScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtColumnScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtColumnScope
{color:red}ERROR:{color} Failed: org.apache.sentry.tests.e2e.hive.TestSandboxOps
{color:red}ERROR:{color} Failed: org.apache.sentry.tests.e2e.hive.TestSandboxOps
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/3442/console
This message is automatically generated.
> isTableEmptyCore method ins SentryStore has references to MAuthzPathsMapping
> when it should be generic
> ------------------------------------------------------------------------------------------------------
>
> Key: SENTRY-2047
> URL: https://issues.apache.org/jira/browse/SENTRY-2047
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
> Affects Versions: 2.0.0
> Reporter: Arjun Mishra
> Assignee: Arjun Mishra
> Labels: newbie
> Attachments: SENTRY-2047.01.patch
>
>
> Current isTableEmpty implementation is below
> {noformat}
> private boolean isTableEmptyCore(PersistenceManager pm, Class clazz) {
> Query query = pm.newQuery(clazz);
> query.addExtension(LOAD_RESULTS_AT_COMMIT, "false");
> // setRange is implemented efficiently for MySQL, Postgresql (using the
> LIMIT SQL keyword)
> // and Oracle (using the ROWNUM keyword), with the query only finding the
> objects required
> // by the user directly in the datastore. For other RDBMS the query will
> retrieve all
> // objects up to the "to" record, and will not pass any unnecessary
> objects that are before
> // the "from" record.
> query.setRange(0, 1);
> return ((List<MAuthzPathsMapping>) query.execute()).isEmpty();
> }
> {noformat}
> We seem to be casting query.execute to a List<MAuthzPathsMapping> when there
> is no need for it
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
