[ 
https://issues.apache.org/jira/browse/SENTRY-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergio Peña updated SENTRY-2088:
--------------------------------
    Description: 
Sentry uses a couple of different APIs to log messages, some are from SLF4J and 
others are from LOG4J dependencies.

For instance:
{noformat}
SLF4J api:
   Logger LOGGER = LoggerFactory.getLogger(GMAuditMetadataLogEntity.class);

LOG4J api:
   Logger LOGGER = LogManager.getLogger(className);
{noformat}

The use of getLogger() is not consistent on Sentry and causes conflicts when 
someone puts a Log4j v2 on the classpath. SLF4J is an interface that uses the 
Log4j implementation detected at runtime. We should use Slf4j APIs to verify 
Sentry can work with any version of Log4j.
   

  was:
Sentry uses a couple of different APIs to log messages, some are from SLF4J and 
others are from LOG4J dependencies.

For instance:
{noformat}
SLF4J api:
   Logger LOGGER = LoggerFactory.getLogger(GMAuditMetadataLogEntity.class);

LOG4J api:
   Logger LOGGER = LogManager.getLogger(className);
{noformat}

SLF4J is an interface that uses the Log4j implementation detected at runtime. 
   


> Use common SLF4J APIs instead of LOG4J directly to allow support of different 
> LOG4J versions
> --------------------------------------------------------------------------------------------
>
>                 Key: SENTRY-2088
>                 URL: https://issues.apache.org/jira/browse/SENTRY-2088
>             Project: Sentry
>          Issue Type: Improvement
>          Components: Sentry
>    Affects Versions: 2.0.0
>            Reporter: Sergio Peña
>              Labels: newbie
>
> Sentry uses a couple of different APIs to log messages, some are from SLF4J 
> and others are from LOG4J dependencies.
> For instance:
> {noformat}
> SLF4J api:
>    Logger LOGGER = LoggerFactory.getLogger(GMAuditMetadataLogEntity.class);
> LOG4J api:
>    Logger LOGGER = LogManager.getLogger(className);
> {noformat}
> The use of getLogger() is not consistent on Sentry and causes conflicts when 
> someone puts a Log4j v2 on the classpath. SLF4J is an interface that uses the 
> Log4j implementation detected at runtime. We should use Slf4j APIs to verify 
> Sentry can work with any version of Log4j.
>    



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to