[
https://issues.apache.org/jira/browse/SENTRY-2085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279455#comment-16279455
]
Zach Amsden commented on SENTRY-2085:
-------------------------------------
[~akolb], I tried to wrap these in appropriate exceptions for the bindings
wherever possible. This is far better than what was happening before,
unchecked exceptions were being leaked out as RuntimeException and blowing up
inside callers. The only cases where a checked exception is issued is where
getGroups() is explicitly called and SentryGroupNotFound exception is raised,
but this should be for internal callers, not the public API bindings.
> Sentry error handling exposes SentryGroupNotFoundException externally
> ---------------------------------------------------------------------
>
> Key: SENTRY-2085
> URL: https://issues.apache.org/jira/browse/SENTRY-2085
> Project: Sentry
> Issue Type: Bug
> Affects Versions: 2.1.0
> Reporter: Zach Amsden
> Assignee: Zach Amsden
> Attachments: SENTRY-2085.001.patch, SENTRY-2085.002.patch,
> SENTRY-2085.003.patch, SENTRY-2085.004.patch
>
>
> The fix for SENTRY-769 allowed better differentiation of Sentry errors but
> also unnecessarily leaked exceptions outside of well defined API components.
> This happens because the exception chosen, SentryGroupNotFoundException was
> created of a subclass of RuntimeError, allowing it to propagate past API
> boundaries without 'throws' or 'catch' clauses.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
