[
https://issues.apache.org/jira/browse/SENTRY-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291392#comment-16291392
]
Na Li commented on SENTRY-2096:
-------------------------------
[~kkalyan] [~spena] Based on my testing results, we should use *--fail-at-end*.
1) with command "mvn verify --fail-at-end", all tests were run and the build is
marked as failure due to some failed test cases. This is desired behavior
{code}
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Sentry ............................................. SUCCESS [ 1.962 s]
[INFO] Sentry Core ........................................ SUCCESS [ 0.123 s]
[INFO] Sentry Core Common ................................. SUCCESS [ 6.822 s]
[INFO] Sentry Core Model DB ............................... SUCCESS [ 1.551 s]
[INFO] Sentry Core Model Indexer .......................... SUCCESS [ 1.086 s]
[INFO] Sentry Core Model Solr ............................. SUCCESS [ 1.579 s]
[INFO] Sentry Core Model Sqoop ............................ SUCCESS [ 1.673 s]
[INFO] Sentry Core Model Kafka ............................ SUCCESS [ 1.000 s]
[INFO] Sentry Policies .................................... SUCCESS [ 0.066 s]
[INFO] Sentry Policy Common ............................... SUCCESS [ 1.640 s]
[INFO] Sentry Providers ................................... SUCCESS [ 0.136 s]
[INFO] Sentry Provider Common ............................. SUCCESS [ 1.146 s]
[INFO] Sentry Provider File ............................... SUCCESS [ 1.719 s]
[INFO] Sentry Policy Engine ............................... SUCCESS [ 0.303 s]
[INFO] Sentry Bindings .................................... SUCCESS [ 0.094 s]
[INFO] Sentry Hive Binding Configuration .................. SUCCESS [ 3.029 s]
[INFO] Hive follower for Sentry ........................... SUCCESS [ 3.789 s]
[INFO] Sentry HDFS ........................................ SUCCESS [ 0.122 s]
[INFO] Sentry HDFS Common ................................. SUCCESS [ 14.834 s]
[INFO] Sentry Provider DB ................................. SUCCESS [09:36 min]
[INFO] Sentry Binding for Kafka ........................... SUCCESS [ 8.526 s]
[INFO] Sentry Provider Cache .............................. SUCCESS [ 1.337 s]
[INFO] Sentry Hive Binding Common ......................... SUCCESS [ 1.586 s]
[INFO] Sentry Binding for Solr ............................ SUCCESS [ 14.299 s]
[INFO] Sentry Binding for Sqoop ........................... SUCCESS [ 6.420 s]
[INFO] Sentry Binding for Hive ............................ SUCCESS [ 15.991 s]
[INFO] Sentry Policy for Indexer .......................... SUCCESS [ 5.829 s]
[INFO] Sentry Solr ........................................ SUCCESS [ 0.069 s]
[INFO] Solr Sentry handler ................................ SUCCESS [ 3.737 s]
[INFO] Sentry Tests ....................................... SUCCESS [ 0.148 s]
[INFO] Sentry Solr Tests .................................. SUCCESS [01:52 min]
[INFO] Sentry Sqoop Tests ................................. SUCCESS [01:43 min]
[INFO] Sentry Kafka Tests ................................. SUCCESS [03:27 min]
[INFO] Sentry HDFS Service ................................ SUCCESS [06:55 min]
[INFO] Sentry HDFS Namenode Plugin ........................ SUCCESS [ 5.963 s]
[INFO] Sentry Hive Tests .................................. FAILURE [ 1.876 s]
[INFO] Sentry HDFS Dist ................................... SUCCESS [ 2.006 s]
[INFO] sentry-tools ....................................... SUCCESS [ 1.592 s]
[INFO] Sentry Distribution ................................ SUCCESS [ 25.775 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
{code}
2) With command "mvn verify -Dmaven.test.failure.ignore=true", all tests were
run and the build was marked as success even with some failed tests. It could
mislead people to believe the code change does not break unit tests, but in
fact it does.
{code}
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Sentry ............................................. SUCCESS [ 12.537 s]
[INFO] Sentry Core ........................................ SUCCESS [ 0.163 s]
[INFO] Sentry Core Common ................................. SUCCESS [ 13.896 s]
[INFO] Sentry Core Model DB ............................... SUCCESS [ 3.708 s]
[INFO] Sentry Core Model Indexer .......................... SUCCESS [ 1.449 s]
[INFO] Sentry Core Model Solr ............................. SUCCESS [ 1.106 s]
[INFO] Sentry Core Model Sqoop ............................ SUCCESS [ 1.428 s]
[INFO] Sentry Core Model Kafka ............................ SUCCESS [ 1.405 s]
[INFO] Sentry Policies .................................... SUCCESS [ 0.089 s]
[INFO] Sentry Policy Common ............................... SUCCESS [ 1.949 s]
[INFO] Sentry Providers ................................... SUCCESS [ 0.142 s]
[INFO] Sentry Provider Common ............................. SUCCESS [ 1.620 s]
[INFO] Sentry Provider File ............................... SUCCESS [ 3.706 s]
[INFO] Sentry Policy Engine ............................... SUCCESS [ 0.749 s]
[INFO] Sentry Bindings .................................... SUCCESS [ 0.285 s]
[INFO] Sentry Hive Binding Configuration .................. SUCCESS [ 6.534 s]
[INFO] Hive follower for Sentry ........................... SUCCESS [ 5.342 s]
[INFO] Sentry HDFS ........................................ SUCCESS [ 0.148 s]
[INFO] Sentry HDFS Common ................................. SUCCESS [ 50.477 s]
[INFO] Sentry Provider DB ................................. SUCCESS [09:56 min]
[INFO] Sentry Binding for Kafka ........................... SUCCESS [ 8.234 s]
[INFO] Sentry Provider Cache .............................. SUCCESS [ 1.224 s]
[INFO] Sentry Hive Binding Common ......................... SUCCESS [ 1.350 s]
[INFO] Sentry Binding for Solr ............................ SUCCESS [ 14.785 s]
[INFO] Sentry Binding for Sqoop ........................... SUCCESS [ 6.306 s]
[INFO] Sentry Binding for Hive ............................ SUCCESS [ 18.913 s]
[INFO] Sentry Policy for Indexer .......................... SUCCESS [ 5.145 s]
[INFO] Sentry Solr ........................................ SUCCESS [ 0.038 s]
[INFO] Solr Sentry handler ................................ SUCCESS [ 3.518 s]
[INFO] Sentry Tests ....................................... SUCCESS [ 0.194 s]
[INFO] Sentry Solr Tests .................................. SUCCESS [01:51 min]
[INFO] Sentry Sqoop Tests ................................. SUCCESS [01:40 min]
[INFO] Sentry Kafka Tests ................................. SUCCESS [04:00 min]
[INFO] Sentry HDFS Service ................................ SUCCESS [06:52 min]
[INFO] Sentry HDFS Namenode Plugin ........................ SUCCESS [ 5.211 s]
[INFO] Sentry Hive Tests .................................. SUCCESS [53:23 min]
[INFO] Sentry HDFS Dist ................................... SUCCESS [ 1.682 s]
[INFO] sentry-tools ....................................... SUCCESS [ 1.318 s]
[INFO] Sentry Distribution ................................ SUCCESS [ 27.171 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:21 h
[INFO] Finished at: 2017-12-14T11:29:24-06:00
[INFO] Final Memory: 388M/1422M
[INFO] ------------------------------------------------------------------------
{code}
> Fail unit tests at end
> ----------------------
>
> Key: SENTRY-2096
> URL: https://issues.apache.org/jira/browse/SENTRY-2096
> Project: Sentry
> Issue Type: Task
> Components: Sentry
> Affects Versions: 2.1.0
> Reporter: Na Li
> Assignee: Na Li
> Attachments: SENTRY-2096.001.patch
>
>
> Currently, when the unit tests fail in one module, the test stops and report
> failure. It is better to run tests in all modules and then report all failed
> tests. So we can fix test failure at once.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
