[
https://issues.apache.org/jira/browse/SENTRY-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302609#comment-16302609
]
Vadim Spector commented on SENTRY-2109:
---------------------------------------
[~kkalyan], could you, please, explain how this patch is going to relate to
SENTRY-2106, since they are trying to address the same issue. This way it will
be easier to do code review.
In my opinion, it would be easier - and safer - to commit SENTRY-2106 first, so
you'd provide your code review on top of it. SENTRY-2106 seems to be pretty
straightforward (once some concerns have been addressed), focusing on one
specific condition and one specific way of avoiding full update. If you provide
your patch on top of it, it would be easier to review it. Otherwise, since both
patches have overlap in the code (trying to fix exactly the same method for
exactly the same purpose), it may be confusing to analyze this patch on its own
while thinking how the two patches will interact after the merge.
> Fix the logic of identifying HMS out of Sync
> --------------------------------------------
>
> Key: SENTRY-2109
> URL: https://issues.apache.org/jira/browse/SENTRY-2109
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
> Affects Versions: 2.1.0
> Reporter: kalyan kumar kalvagadda
> Assignee: kalyan kumar kalvagadda
> Fix For: 2.1.0
>
> Attachments: SENTRY-2109.001.patch,
> Screenshot_HMS_NOTIFICATION_LOG.png
>
>
> Currently HMSFollower proactively checks if sentry is out of sync with HMS
> and initiates full snapshot, if needed.
> There will be false positives with the current logic if there are gaps in the
> event-id in the notification log sequence.
> This jira is aimed at making that logic robust.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
