[
https://issues.apache.org/jira/browse/SENTRY-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366362#comment-16366362
]
Xinran Tinney commented on SENTRY-2089:
---------------------------------------
[~spena] THIRD_PARTY.properties changes based on the corresponding pom change,
if there is a pom change, mojo plugin update it automatically. if it is just
comment, it can be ignored, but sometimes new dependencies information is added
to THIRD_PARTY.properties. on what situation, do we want to ignore the
modification?
> Avoid THIRD-PARTY.properties source file being modified on every build
> ----------------------------------------------------------------------
>
> Key: SENTRY-2089
> URL: https://issues.apache.org/jira/browse/SENTRY-2089
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
> Affects Versions: 2.0.0
> Reporter: Sergio Peña
> Assignee: Xinran Tinney
> Priority: Major
>
> Every time I build sentry, I see the following unstaged changes on the master
> branch:
> {noformat}
> On branch master
> Your branch is up-to-date with 'apache/master'.
> Changes not staged for commit:
> (use "git add <file>..." to update what will be committed)
> (use "git checkout -- <file>..." to discard changes in working directory)
> modified: sentry-dist/src/license/THIRD-PARTY.properties
> no changes added to commit (use "git add" and/or "git commit -a")
> {noformat}
> We should investigate and avoid modifying such file because sometimes
> developers may do mistakes and run {{git add .}} and commit the patch with
> such new modification committed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
