[
https://issues.apache.org/jira/browse/SENTRY-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379075#comment-16379075
]
Hadoop QA commented on SENTRY-2145:
-----------------------------------
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12912278/SENTRY-2145.patch
against master.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} all tests passed
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/3676/console
This message is automatically generated.
> Some misc code cleanups
> -----------------------
>
> Key: SENTRY-2145
> URL: https://issues.apache.org/jira/browse/SENTRY-2145
> Project: Sentry
> Issue Type: Improvement
> Reporter: Colm O hEigeartaigh
> Assignee: Colm O hEigeartaigh
> Priority: Trivial
> Fix For: 2.1.0
>
> Attachments: SENTRY-2145.patch
>
>
> This task is to implement some misc code cleanups:
> a) Use StringBuilder instead of looping and using "+" with a String
> b) Use EntrySet instead of KeySet when the value is also required
> c) Make sure constants are static final.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
