[
https://issues.apache.org/jira/browse/SENTRY-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416263#comment-16416263
]
Hadoop QA commented on SENTRY-2188:
-----------------------------------
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12916468/SENTRY-2188.001.patch
against master.
{color:red}Overall:{color} -1 due to an error
{color:red}ERROR:{color} failed to apply patch (exit code 1):
The patch does not appear to apply with p0, p1, or p2
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/3718/console
This message is automatically generated.
> 75+ files are uneccessarily changed when generetating new Thrift files.
> -----------------------------------------------------------------------
>
> Key: SENTRY-2188
> URL: https://issues.apache.org/jira/browse/SENTRY-2188
> Project: Sentry
> Issue Type: Bug
> Components: Build
> Affects Versions: 2.0.0
> Reporter: Steve Moist
> Assignee: Steve Moist
> Priority: Minor
> Attachments: SENTRY-2188.001.patch
>
>
> When modifying the thrift apis, the developer needs to regenerate the thrift
> model. When that happens, the thrift portion of the build unnecessarily
> touches 75+ generated thrift files with a new timestamp. No actual code or
> bindings is affected. From a developer perspective, this is bad as the
> developer has to undo those changes to the 75+ files. We should modify how
> the thrift api's are generated so that they do not regenerate old changes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
