[
https://issues.apache.org/jira/browse/SENTRY-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582820#comment-16582820
]
Hadoop QA commented on SENTRY-1944:
-----------------------------------
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12902923/SENTRY-1944.03.patch
against master.
{color:red}Overall:{color} -1 due to an error
{color:red}ERROR:{color} failed to apply patch (exit code 1):
error:
a/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java:
does not exist in index
error:
a/sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestDelegateSentryStore.java:
does not exist in index
error:
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java:
does not exist in index
error:
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestDelegateSentryStore.java:
does not exist in index
error:
sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java:
does not exist in index
error:
sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestDelegateSentryStore.java:
does not exist in index
The patch does not appear to apply with p0, p1, or p2
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/4038/console
This message is automatically generated.
> Optimize DelegateSentryStore.getGroupsByRoles() and update
> SentryGenericPolicyProcessor to retrieve roles to group mapping in a single
> transaction
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SENTRY-1944
> URL: https://issues.apache.org/jira/browse/SENTRY-1944
> Project: Sentry
> Issue Type: Improvement
> Components: Sentry
> Affects Versions: 2.0.0
> Reporter: Alexander Kolbasov
> Assignee: Arjun Mishra
> Priority: Major
> Attachments: SENTRY-1944.01.patch, SENTRY-1944.02.patch,
> SENTRY-1944.03.patch
>
>
> When Solr is using Sentry server for authorization, it issues a lot of calls
> to {{getGroupsByRoles()}} function in {{DelegateSentryStore}}.
> This function isn't very efficient - it walks over each role in the set,
> obtains role by name, get groups for each role, and collects all group names
> into a set.
> It may be possible to optimize it.
> Also, in SentryGenericPolicyProcessor class method
> list_sentry_roles_by_group() would make N transactions to build the roles to
> set of groups map. Instead, make it to a single transaction. This will
> significantly speed up operation
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
