[ 
https://issues.apache.org/jira/browse/SENTRY-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613783#comment-16613783
 ] 

Hadoop QA commented on SENTRY-1429:
-----------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12857561/SENTRY-1429.001-sentry-ha-redesign.patch
 against sentry-ha-redesign.

{color:red}Overall:{color} -1 due to an error

{color:red}ERROR:{color} failed to apply patch (exit code 1):
The patch does not appear to apply with p0, p1, or p2



Console output: 
https://builds.apache.org/job/PreCommit-SENTRY-Build/4109/console

This message is automatically generated.

> TestHDFSIntegration improvements
> --------------------------------
>
>                 Key: SENTRY-1429
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1429
>             Project: Sentry
>          Issue Type: Test
>          Components: Sentry, Test
>    Affects Versions: 1.8.0, 2.0.0
>            Reporter: Sravya Tirukkovalur
>            Priority: Major
>         Attachments: SENTRY-1429.001-sentry-ha-redesign.patch
>
>
> There are a few problems with this test that would be good to fix:
> 1. NN pulls the Sentry acls periodically, which means tests cannot verify 
> acls as soon as it sets up the required privileges. This requires having 
> sleeps in the test but it leads to some flakyness. We need to make sure we 
> are actually sleeping after setting the permissions and before veryfying. Or 
> explore other options to make this robust.
> 2. We need to make the tests more granular. There is a bunch of stuff 
> happening in a single test, so it is hard to pinpoint why a test failed 
> without looking at the stacktrace and debugging further.
> 3. Fix inter test dependencies if any. I see that some tests pass if run 
> alone, but fail when the entire test class is run, so there might be some 
> dependencies which we need to clean up.
> 4. Make these tests runnable on real cluster. So that we can catch any 
> integration and configuration issues.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to