[ https://issues.apache.org/jira/browse/SENTRY-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726608#comment-16726608 ]
zhaohongtao edited comment on SENTRY-2469 at 12/21/18 10:17 AM: ---------------------------------------------------------------- Hi, I have fixed this issue , thanks https://reviews.apache.org/r/69618/ was (Author: hongtaq): Hi, I have fixed this issue , thanks https://reviews.apache.org/r/69617/ > Fix bugs in RoleServlet > ----------------------- > > Key: SENTRY-2469 > URL: https://issues.apache.org/jira/browse/SENTRY-2469 > Project: Sentry > Issue Type: Bug > Components: Sentry > Affects Versions: 2.2.0 > Reporter: Na Li > Priority: Major > > Fredy found several issues in RoleServlet.java. We need to fix it. > 1. `RoleServlet` at L62 needs to use either `try` resource or put it in the > `finally` block to avoid resource leak > 2. `if (conf.getBoolean(ServerConfig.SENTRY_WEB_ENABLE, > ServerConfig.SENTRY_WEB_ENABLE_DEFAULT))` may return an NPE if > `conf.getBoolean` returns a `null` `Boolean` (not the primitive type) > 3. `RoleServlet` at L45, use `Preconditions.checkNotNull` or > `Objects.requreNonNull` instead of `assert` > 4. `RoleServlet` at L55: `String json = new Gson().toJson(roleMap);`, it's > better to reuse the `Gson` instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)