[
https://issues.apache.org/jira/browse/SCB-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303821#comment-16303821
]
ASF GitHub Bot commented on SCB-131:
------------------------------------
little-cui closed pull request #228: SCB-131 Do not check the micro-service
description field in registration.
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/228
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/server/core/common.go b/server/core/common.go
index d4228342..6efbae3e 100644
--- a/server/core/common.go
+++ b/server/core/common.go
@@ -65,7 +65,7 @@ func init() {
// version模糊规则: 1.0, 1.0+, 1.0-2.0, latest
versionFuzzyRegex, _ :=
regexp.Compile(`^[0-9]*$|^[0-9]+(\.[0-9]+)*\+{0,1}$|^[0-9]+(\.[0-9]+)*-[0-9]+(\.[0-9]+)*$|^latest$`)
pathRegex, _ := regexp.Compile(`^[A-Za-z0-9.,?'\\/+&%$#=~_\-@{}]*$`)
- descriptionRegex, _ := regexp.Compile(`^[\p{Han}\w\s。.:*,\-：”“"]*$`)
+ // descriptionRegex, _ := regexp.Compile(`^[\p{Han}\w\s。.:*,\-：”“"]*$`)
levelRegex, _ := regexp.Compile(`^(FRONT|MIDDLE|BACK)$`)
statusRegex, _ := regexp.Compile("^(" + pb.MS_UP + "|" + pb.MS_DOWN +
")*$")
serviceIdRegex, _ := regexp.Compile(`^.*$`)
@@ -111,7 +111,7 @@ func init() {
FrameWKValidator.AddRule("Version", &validate.ValidateRule{Length: 64,
Regexp: frameversionRegex})
MicroServiceValidator.AddRules(MicroServiceKeyValidator.GetRules())
- MicroServiceValidator.AddRule("Description",
&validate.ValidateRule{Length: 256, Regexp: descriptionRegex})
+ MicroServiceValidator.AddRule("Description",
&validate.ValidateRule{Length: 256})
MicroServiceValidator.AddRule("Level", &validate.ValidateRule{Min: 1,
Regexp: levelRegex})
MicroServiceValidator.AddRule("Status", &validate.ValidateRule{Min: 1,
Regexp: statusRegex})
MicroServiceValidator.AddRule("Schemas", SchemaIdRule)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Do not check the micro-service description field in registration
> ----------------------------------------------------------------
>
> Key: SCB-131
> URL: https://issues.apache.org/jira/browse/SCB-131
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Service-Center
> Reporter: little-cui
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
