[
https://issues.apache.org/jira/browse/SCB-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312763#comment-16312763
]
ASF GitHub Bot commented on SCB-182:
------------------------------------
codecov-io commented on issue #244: SCB-182 Registry client option 'WithStrKey'
will set the wrong key as using non-copy string function.
URL:
https://github.com/apache/incubator-servicecomb-service-center/pull/244#issuecomment-355509350
#
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/244?src=pr&el=h1)
Report
> Merging
[#244](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/244?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/b4e3984b6ceb290e6effbd93b04959b59e2af792?src=pr&el=desc)
will **increase** coverage by `0.11%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/244?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #244 +/- ##
==========================================
+ Coverage 68.78% 68.89% +0.11%
==========================================
Files 17 17
Lines 3556 3556
==========================================
+ Hits 2446 2450 +4
+ Misses 936 933 -3
+ Partials 174 173 -1
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/244?src=pr&el=tree)
| Coverage Δ | |
|---|---|---|
|
[server/service/service\_dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/244/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvc2VydmljZV9kZXBlbmRlbmN5Lmdv)
| `75% <0%> (-0.87%)` | :arrow_down: |
|
[server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/244/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv)
| `70.92% <0%> (+0.16%)` | :arrow_up: |
|
[server/service/microservices.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/244/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlcy5nbw==)
| `73.63% <0%> (+0.78%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/244?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/244?src=pr&el=footer).
Last update
[b4e3984...fe5b673](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/244?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Registry client option 'WithStrKey' will set the wrong key as using non-copy
> string function
> --------------------------------------------------------------------------------------------
>
> Key: SCB-182
> URL: https://issues.apache.org/jira/browse/SCB-182
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Service-Center
> Reporter: little-cui
> Assignee: little-cui
> Fix For: service-center-1.0.0-m1
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
