[ 
https://issues.apache.org/jira/browse/SCB-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312836#comment-16312836
 ] 

ASF GitHub Bot commented on SCB-36:
-----------------------------------

eric-lee-ltk commented on a change in pull request #489: [WIP] SCB-36 Support 
dynamic configuration for chassis by integrating with …
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r159840126
 
 

 ##########
 File path: 
dynamic-config/config-apollo/src/main/java/io/servicecomb/config/archaius/sources/ApolloConfigurationSourceImpl.java
 ##########
 @@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package io.servicecomb.config.archaius.sources;
+
+import static com.netflix.config.WatchedUpdateResult.createIncremental;
+
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.CopyOnWriteArrayList;
+
+import org.apache.commons.configuration.Configuration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.Maps;
+import com.netflix.config.ConcurrentCompositeConfiguration;
+import com.netflix.config.WatchedUpdateListener;
+import com.netflix.config.WatchedUpdateResult;
+
+import io.servicecomb.config.ConfigMapping;
+import io.servicecomb.config.client.ApolloClient;
+import io.servicecomb.config.client.ApolloConfig;
+import io.servicecomb.config.spi.ConfigCenterConfigurationSource;
+
+public class ApolloConfigurationSourceImpl implements 
ConfigCenterConfigurationSource {
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(ConfigCenterConfigurationSource.class);
+
+  private final Map<String, Object> valueCache = Maps.newConcurrentMap();
+
+  private List<WatchedUpdateListener> listeners = new 
CopyOnWriteArrayList<WatchedUpdateListener>();
+
+  public ApolloConfigurationSourceImpl() {
+  }
+
+  private UpdateHandler updateHandler = new UpdateHandler();
 
 Review comment:
   final pls.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Support connecting to the third party dynamic config center
> -----------------------------------------------------------
>
>                 Key: SCB-36
>                 URL: https://issues.apache.org/jira/browse/SCB-36
>             Project: Apache ServiceComb
>          Issue Type: Sub-task
>          Components: Java-Chassis
>            Reporter: mabin
>            Assignee: mabin
>             Fix For: java-chassis-1.0.0-m1
>
>         Attachments: Dynamic Config Proposal.pdf
>
>
> Java-chassis can connect to another open source config center to support 
> changing the setting dynamically.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to