[
https://issues.apache.org/jira/browse/SCB-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315269#comment-16315269
]
ASF GitHub Bot commented on SCB-36:
-----------------------------------
wujimin commented on a change in pull request #489: [WIP] SCB-36 Support
dynamic configuration for chassis by integrating with …
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r160049859
##########
File path:
dynamic-config/config-apollo/src/main/java/io/servicecomb/config/client/ApolloConfig.java
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package io.servicecomb.config.client;
+
+import com.netflix.config.ConcurrentCompositeConfiguration;
+
+public class ApolloConfig {
+ public static final ApolloConfig INSTANCE = new ApolloConfig();
+
+ private static ConcurrentCompositeConfiguration finalConfig;
+
+ private static final String SERVER_URL_KEY = "apollo.config.serverUri";
+
+ private static final String SERVER_NAMESPACE = "apollo.config.namespace";
+
+ private static final String SERVER_ENV = "apollo.config.env";
+
+ private static final String SERVER_CLUSTERS = "apollo.config.clusters";
+
+ private static final String APOLLO_SERVICE_NAME =
"apollo.config.serviceName";
+
+ private static final String TOKEN = "apollo.config.token";
+
+ private static final String REFRESH_INTERVAL =
"apollo.config.refreshInterval";
+
+ private static final String FIRST_REFRESH_INTERVAL =
"apollo.config.firstRefreshInterval";
+
+ private static final int DEFAULT_REFRESH_INTERVAL = 3;
+
+ private static final int DEFAULT_FIRST_REFRESH_INTERVAL = 0;
+
+ private ApolloConfig() {
+ }
+
+ public static void
setConcurrentCompositeConfiguration(ConcurrentCompositeConfiguration config) {
Review comment:
must be a ConcurrentCompositeConfiguration ?
it's seems that org.apache.commons.configuration.Configuration is enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support connecting to the third party dynamic config center
> -----------------------------------------------------------
>
> Key: SCB-36
> URL: https://issues.apache.org/jira/browse/SCB-36
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
> Reporter: mabin
> Assignee: mabin
> Fix For: java-chassis-1.0.0-m1
>
> Attachments: Dynamic Config Proposal.pdf
>
>
> Java-chassis can connect to another open source config center to support
> changing the setting dynamically.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
