[
https://issues.apache.org/jira/browse/SCB-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317845#comment-16317845
]
ASF GitHub Bot commented on SCB-36:
-----------------------------------
lijasonvip commented on a change in pull request #489: [WIP] SCB-36 Support
dynamic configuration for chassis by integrating with …
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/489#discussion_r160328970
##########
File path:
foundations/foundation-config/src/main/java/io/servicecomb/config/ConfigUtil.java
##########
@@ -151,7 +153,8 @@ private static void
duplicateServiceCombConfigToCse(ConcurrentCompositeConfigura
}
public static DynamicWatchedConfiguration
createConfigFromConfigCenter(Configuration localConfiguration) {
- if (localConfiguration.getProperty(configCenterUrlKey) == null) {
+ if (localConfiguration.getProperty(configCenterUrlKey) == null &&
Review comment:
Currently, I remove newly added control flag and use original
cse.config.client.serverUri to control. Need some help about how map different
key to make this more elegant. I appreciate everything you do for me @wujimin.
thanks again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support connecting to the third party dynamic config center
> -----------------------------------------------------------
>
> Key: SCB-36
> URL: https://issues.apache.org/jira/browse/SCB-36
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
> Reporter: mabin
> Assignee: mabin
> Fix For: java-chassis-1.0.0-m1
>
> Attachments: Dynamic Config Proposal.pdf
>
>
> Java-chassis can connect to another open source config center to support
> changing the setting dynamically.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
