[
https://issues.apache.org/jira/browse/SCB-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325963#comment-16325963
]
ASF GitHub Bot commented on SCB-227:
------------------------------------
seanyinx commented on a change in pull request #114: SCB-227 stop sub tx from
running when global tx failed
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/114#discussion_r161443701
##########
File path:
omega/omega-connector/omega-connector-grpc/src/main/java/org/apache/servicecomb/saga/omega/connector/grpc/LoadBalancedClusterMessageSender.java
##########
@@ -124,14 +125,15 @@ public void close() {
}
@Override
- public void send(TxEvent event) {
+ public AlphaResponse send(TxEvent event) {
+ AlphaResponse response = null;
Review comment:
have to think about when this response will be returned, and the consequence
of returning this response under such a scenario. apparently it's only possible
when this thread is interrupted and throwing an exception is a better idea in
such case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [pack] stop sub transaction from running when global tx failed
> --------------------------------------------------------------
>
> Key: SCB-227
> URL: https://issues.apache.org/jira/browse/SCB-227
> Project: Apache ServiceComb
> Issue Type: New Feature
> Components: Saga
> Reporter: Yin Xiang
> Assignee: Eric Lee
> Priority: Major
>
> sub transactions may be started in parallel among multiple services.
> if one of them failed, none of them shall start at all, if not already
> started.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
