[
https://issues.apache.org/jira/browse/SCB-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336861#comment-16336861
]
ASF GitHub Bot commented on SCB-269:
------------------------------------
codecov-io commented on issue #258: SCB-269 remove lock for dependency handle
URL:
https://github.com/apache/incubator-servicecomb-service-center/pull/258#issuecomment-360014173
#
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258?src=pr&el=h1)
Report
> Merging
[#258](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/eaee0005a10a4e2425be145ad640a952975d7d31?src=pr&el=desc)
will **increase** coverage by `0.4%`.
> The diff coverage is `81.25%`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #258 +/- ##
=========================================
+ Coverage 69.78% 70.18% +0.4%
=========================================
Files 17 17
Lines 3488 3465 -23
=========================================
- Hits 2434 2432 -2
+ Misses 885 863 -22
- Partials 169 170 +1
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258?src=pr&el=tree)
| Coverage Δ | |
|---|---|---|
|
[server/service/service\_dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvc2VydmljZV9kZXBlbmRlbmN5Lmdv)
| `73.04% <0%> (-1.74%)` | :arrow_down: |
|
[server/service/microservices.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlcy5nbw==)
| `74.05% <100%> (+0.33%)` | :arrow_up: |
|
[server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv)
| `57.16% <84.61%> (+1.82%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258?src=pr&el=footer).
Last update
[eaee000...08ed777](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Dependency use domain-project-env level lock
> --------------------------------------------
>
> Key: SCB-269
> URL: https://issues.apache.org/jira/browse/SCB-269
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Service-Center
> Reporter: little-cui
> Assignee: little-cui
> Priority: Major
> Fix For: service-center-1.0.0-m1
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
