[
https://issues.apache.org/jira/browse/SCB-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338573#comment-16338573
]
ASF GitHub Bot commented on SCB-224:
------------------------------------
seanyinx commented on a change in pull request #117: SCB-224 support retry
sub-transaction
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/117#discussion_r163727595
##########
File path:
alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/EventScanner.java
##########
@@ -75,11 +72,11 @@ private void pollEvents() {
}
private void saveUncompensatedEventsToCommands() {
-
eventRepository.findFirstUncompensatedEventByIdGreaterThan(nextEndedEventId,
TxEndedEvent.name())
+ eventRepository.findByTypeAndIdGreaterThan(nextAbortedEventId,
TxAbortedEvent.name())
Review comment:
we can't fully depend on AbortedEvent here, since TxStartedEvent and
TxEndedEvent of some sub transaction may arrive later, causing some events are
not compensated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [pack] retry sub-transaction on failure
> ---------------------------------------
>
> Key: SCB-224
> URL: https://issues.apache.org/jira/browse/SCB-224
> Project: Apache ServiceComb
> Issue Type: New Feature
> Components: Saga
> Reporter: Yin Xiang
> Priority: Major
>
> as a user, i want to retry transaction in my service, so that it can always
> be done eventually.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
